GH-3558: Bump hadoop to 3.4.3 and properly close buffers for vectored IO#3620
Open
nastra wants to merge 2 commits into
Open
GH-3558: Bump hadoop to 3.4.3 and properly close buffers for vectored IO#3620nastra wants to merge 2 commits into
nastra wants to merge 2 commits into
Conversation
nastra
changed the title
nastra
changed the title
Contributor
Author
Member
|
Wondering if my approach for the same issue in https://github.com/apache/parquet-java/pull/3579/changes#diff-8da24c84aef62e6e836d073938f7843d289785baaeddf446f3afeae6d4ef4b10R1368 If anyone here knows someone who can help us get this reviewed/merged on the Hadoop side that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This closes allocated buffers for vectored IO, because after updating to Hadoop > 3.4.x we see a bunch of failing tests where buffers are not properly closed.
Closes #3558
Closes #3356
What changes are included in this PR?
Are these changes tested?
existing tests
Are there any user-facing changes?