[iceberg] Fix missing parent snapshot id in createMetadataWithoutBase#8305
Open
weibangpeng wants to merge 1 commit into
Open
[iceberg] Fix missing parent snapshot id in createMetadataWithoutBase#8305weibangpeng wants to merge 1 commit into
weibangpeng wants to merge 1 commit into
Conversation
When createMetadataWithoutBase is used for non-first snapshots, the parent_id was incorrectly set to null, breaking Iceberg's snapshot parent chain and preventing operations like create_changelog_view from working correctly. Closes apache#5860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parent_idincorrectly set tonullfor non-first snapshots whencreateMetadataWithoutBaseis usedparentId = snapshotId - 1instead ofnullRoot cause
When previous Iceberg metadata files are expired,
createMetadatafalls back tocreateMetadataWithoutBase, which hardcodedparentId = nullregardless of whether it's the first snapshot or not. This breaks the Iceberg snapshot parent chain.Fix
Use
snapshotId - 1asparentIdfor non-first snapshots (snapshot 1 correctly keepsparentId = null).Closes #5860