Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

test(e2e): replace browser.getLocationAbsUrl() deprecated function with browser.getCurrentUrl()#16053

Closed
alopezsanchez wants to merge 2 commits into
angular:masterfrom
alopezsanchez:test-change-getlocationabsurl
Closed

test(e2e): replace browser.getLocationAbsUrl() deprecated function with browser.getCurrentUrl()#16053
alopezsanchez wants to merge 2 commits into
angular:masterfrom
alopezsanchez:test-change-getlocationabsurl

Conversation

@alopezsanchez

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test

What is the current behavior? (You can also link to an open issue here)
There are many references to browser.getLocationAbsUrl() deprecated function (Protractor).
A warning appears when e2e tests are running, it recommend using browser.getCurrentUrl() instead.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:
Tutorial documentation references also updated.

…th browser.getCurrentUrl()

According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
…urrentUrl()

According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
@alopezsanchez

Copy link
Copy Markdown
Contributor Author

Hello! Can anyone tell me why the CI build failed? Thanks.

@Narretz

Narretz commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

Did you take a look at the logs on Travis? Usually they have some info. It's also possible that this is a flake.

@alopezsanchez

alopezsanchez commented Jun 15, 2017

Copy link
Copy Markdown
Contributor Author

@Narretz Yes I did. There is a connection refused:

20170615 000024.559 [4421] PROXY 127.0.0.1:35020 -> POST http://localhost:9876/socket.io/?EIO=3&transport=polling&t=Lof3Fvn&sid=r73fxRiwJquSKEYQAAAV (644 bytes)

20170615 000024.559 [4421] PROXY 127.0.0.1:35020 <- localhost:9876 connection error: Connection refused

Can you rebuild it?

Thanks!

@Narretz

Narretz commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

Restarted.

Note that this must be changed in https://github.com/angular/angular-phonecat, too. For that we also need to check we are using an up to date Protractor version.

@alopezsanchez

Copy link
Copy Markdown
Contributor Author

Hello @Narretz. I can do it. Is there a problem updating Protractor version?

@Narretz

Narretz commented Jun 15, 2017 via email

Copy link
Copy Markdown
Contributor

@gkalpak

gkalpak commented Nov 14, 2018

Copy link
Copy Markdown
Member

The tutorial changes (which are invalid as they are in this PR) are being taken care of in #16753 and angular/angular-phonecat#430.
The other e2e change is valid 👍

@gkalpak gkalpak closed this in 318e6ce Nov 15, 2018
gkalpak pushed a commit that referenced this pull request Nov 15, 2018
…`browser.getCurrentUrl()`

According to angular/protractor#3969, `browser.getLocationAbsUrl()` is
now deprecated and `browser.getCurrentUrl()` should be used instead.

Closes #16053
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants