Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(guide): add dart version of structural directives#696

Closed
adaojunior wants to merge 6 commits into
angular:masterfrom
adaojunior:structural-directives
Closed

docs(guide): add dart version of structural directives#696
adaojunior wants to merge 6 commits into
angular:masterfrom
adaojunior:structural-directives

Conversation

@adaojunior

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/common/directives.dart -> common.dart

@kwalrath

Copy link
Copy Markdown
Contributor

Good work! I left a bunch of nitty comments, but I think the code is good. I'll ask @sanfordredlich to be the real technical reviewer.

@kwalrath

Copy link
Copy Markdown
Contributor

LGTM! I'll wait for a real technical reviewer to have a look before merging this.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like it this way but the style guide says to omit {} when they are not required

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants