Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(hierarchical-di): post-RC5 Dart resync#2080

Merged
kwalrath merged 1 commit into
angular:masterfrom
IdeaBlade:chalin-dart-hier-di-rc5-resync-0810
Aug 11, 2016
Merged

docs(hierarchical-di): post-RC5 Dart resync#2080
kwalrath merged 1 commit into
angular:masterfrom
IdeaBlade:chalin-dart-hier-di-rc5-resync-0810

Conversation

@chalin

@chalin chalin commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

Contributes to #2077.
Depends on #2078.

@chalin

chalin commented Aug 10, 2016

Copy link
Copy Markdown
Contributor Author

@kwalrath @Foxandxss : ready to be reviewed. The changes are simple enough that it might be sufficient for Kathy to review.

@chalin chalin force-pushed the chalin-dart-hier-di-rc5-resync-0810 branch from 51de12f to e4d3937 Compare August 10, 2016 20:54
@kwalrath

Copy link
Copy Markdown
Contributor

LGTM (both TS & Dart)

@chalin chalin force-pushed the chalin-dart-hier-di-rc5-resync-0810 branch from e4d3937 to fe6fb8a Compare August 11, 2016 15:54
@chalin

chalin commented Aug 11, 2016

Copy link
Copy Markdown
Contributor Author

@kwalrath @Foxandxss @wardbell : I've decided to keep the _cache fresh rather than minimal (i.e., rather than delete cache files as they are no longer needed). This way, we can now see the diff between the cache and the current file version.

So, FYI, the update I just pushed has a refreshed cache file for this chapter (but no other changes).

@chalin chalin force-pushed the chalin-dart-hier-di-rc5-resync-0810 branch 2 times, most recently from 6ca9664 to 99ff8ec Compare August 11, 2016 16:17
@chalin chalin force-pushed the chalin-dart-hier-di-rc5-resync-0810 branch from 99ff8ec to 793e998 Compare August 11, 2016 16:18
@kwalrath kwalrath merged commit 7075cdb into angular:master Aug 11, 2016
@kwalrath kwalrath deleted the chalin-dart-hier-di-rc5-resync-0810 branch August 11, 2016 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants