This repository was archived by the owner on Dec 4, 2017. It is now read-only.
test(e2e/dart): enable Basics chapter e2e testing#1524
Merged
Conversation
Contributor
Author
Contributor
|
I see "no changes" to those 4 files, for some reason. |
Contributor
Author
|
@kwalrath : it is because they are just empty files; their presence enables the e2e tests. |
Contributor
|
I'm not sure what the protocol is when the CI build fails... @naomiblack? @wardbell? |
Contributor
Author
|
@kwalrath : as far as I understand, the travis build is still under development. In fact the build is failing because of the build setup. So I believe that this failure is safe to ignore until Travis CI is officially supported. |
Contributor
|
I didn't know that we HAD a travis build. I knew we were working on it. Regardless, this LGTM |
Contributor
|
Cool, merging now... |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1522 in part.