Add collisions#14787
Conversation
for more information, see https://pre-commit.ci
Add collisions
for more information, see https://pre-commit.ci
…into add-collisions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into add-collisions
for more information, see https://pre-commit.ci
diusazzad
left a comment
There was a problem hiding this comment.
"Hey @autobotx343! Thanks for this contribution!
I noticed that the PR is currently marked with a "tests are failing" status. Have you had a chance to check the CI/CD logs to see which specific test is failing? If you need help debugging or understanding the error message, feel free to share the logs here, and I'd be happy to take a look!
…into add-collisions
for more information, see https://pre-commit.ci
…into add-collisions
for more information, see https://pre-commit.ci
diusazzad
left a comment
There was a problem hiding this comment.
just a few minor suggestions to make it even more robust:
Docstring Completeness: Everything is great, but could you add the Time and Space Complexity to the class/function docstrings? It’s a standard requirement for all algorithms in this repository.
for more information, see https://pre-commit.ci
…into add-collisions
for more information, see https://pre-commit.ci
|
@diusazzad, thank you for the feedback I have added time complexity and space complexity to the collisions.py file. Further I also contributed to the potential_energy.py file. I wanted to make that a separate pull request, but I am still new to contributing and had some issues with git. |
Describe your change:
Checklist: