Add PadovanSequence Implementation#7477
Open
Rosander0 wants to merge 1 commit into
Open
Conversation
Rosander0
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7477 +/- ##
============================================
+ Coverage 79.82% 79.83% +0.01%
- Complexity 7312 7316 +4
============================================
Files 804 805 +1
Lines 23767 23781 +14
Branches 4676 4678 +2
============================================
+ Hits 18971 18985 +14
Misses 4036 4036
Partials 760 760 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a Padovan sequence implementation to the com.thealgorithms.maths package, along with a JUnit test suite to validate correctness and input validation behavior.
Changes:
- Introduces
PadovanSequenceutility class with an iterativepadovan(int)implementation. - Adds
PadovanSequenceTestcovering base cases, known values, and negative-input handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/thealgorithms/maths/PadovanSequence.java | Adds Padovan sequence computation with input validation and class-level documentation. |
| src/test/java/com/thealgorithms/maths/PadovanSequenceTest.java | Adds unit tests for base cases, known outputs, and invalid input behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,43 @@ | |||
| package com.thealgorithms.maths; | |||
| // author: Vraj Prajapati @Rosander0 | |||
| @@ -0,0 +1,34 @@ | |||
| package com.thealgorithms.maths; | |||
| // author: Vraj Prajapati @Rosander0 | |||
Comment on lines
+25
to
+27
| if (n < 0) { | ||
| throw new IllegalArgumentException("Input must be non-negative!"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java