Add SociableNumber Implementation#7475
Open
Rosander0 wants to merge 1 commit into
Open
Conversation
Rosander0
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7475 +/- ##
============================================
+ Coverage 79.80% 79.82% +0.02%
- Complexity 7302 7314 +12
============================================
Files 803 804 +1
Lines 23751 23766 +15
Branches 4671 4676 +5
============================================
+ Hits 18955 18972 +17
Misses 4036 4036
+ Partials 760 758 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rosander0
force-pushed
the
add-sociable-number
branch
2 times, most recently
from
d58f8a5 to
6867c86
Compare
Rosander0
changed the title
Rosander0
force-pushed
the
add-sociable-number
branch
from
6867c86 to
f4ed961
Compare
Rosander0
force-pushed
the
add-sociable-number
branch
from
31f86fa to
f37df6b
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new number-theory algorithm for detecting whether a given integer belongs to a sociable-number cycle of a specified length, along with JUnit tests validating known sociable/amicable examples and invalid inputs.
Changes:
- Introduce
SociableNumberutility withisSociable(number, cycleLength)and a proper-divisor-sum helper. - Add
SociableNumberTestcovering a length-5 sociable cycle, amicable pairs (length 2), non-sociable values, and invalid inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/main/java/com/thealgorithms/maths/SociableNumber.java | New sociable-number implementation (isSociable) and proper-divisor-sum helper. |
| src/test/java/com/thealgorithms/maths/SociableNumberTest.java | New unit tests for sociable-cycle detection and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+14
| package com.thealgorithms.maths; | ||
| // author: Vraj Prajapati @Rosander0 | ||
|
|
||
| /** | ||
| * Sociable numbers are natural numbers that form a cyclic sequence where the | ||
| * sum of proper divisors of each number equals the next number in the sequence, | ||
| * with the sequence eventually returning to the starting number. | ||
| * Amicable numbers are a special case of sociable numbers with a cycle length of 2. | ||
| * Example: (12496, 14288, 15472, 14536, 14264) is a sociable cycle of length 5. | ||
| * | ||
| * @see <a href="https://en.wikipedia.org/wiki/Sociable_number"> | ||
| * Wikipedia: Sociable Number</a> | ||
| * @see AmicableNumber | ||
| */ |
Comment on lines
+21
to
+32
| static int sumOfProperDivisors(final int number) { | ||
| if (number <= 0) { | ||
| return 0; | ||
| } | ||
| int sum = 0; | ||
| for (int i = 1; i < number; i++) { | ||
| if (number % i == 0) { | ||
| sum += i; | ||
| } | ||
| } | ||
| return sum; | ||
| } |
Comment on lines
+1
to
+10
| package com.thealgorithms.maths; | ||
| // author: Vraj Prajapati @Rosander0 | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class SociableNumberTest { |
Comment on lines
+39
to
+40
| // 220 has cycle length 2, asking for length 3 hits line 60 | ||
| // because current returns to 220 at step 2, but cycleLength-1 = 2 != 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java