Skip to content

Clarification of caching behavior#3102

Closed
aryzing wants to merge 1 commit into
TanStack:masterfrom
aryzing:patch-1
Closed

Clarification of caching behavior#3102
aryzing wants to merge 1 commit into
TanStack:masterfrom
aryzing:patch-1

Conversation

@aryzing

@aryzing aryzing commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

The example contains at least one inacurate statement,

It will then cache the data using 'todos' and fetchTodos as the unique identifiers for that cache.

and could benefit from more precise language.

@vercel

vercel Bot commented Dec 16, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/6iZQE8V4izV4NKkmpLgA6haq9T9s
✅ Preview: https://react-query-git-fork-aryzing-patch-1-tanstack.vercel.app

@codesandbox-ci

codesandbox-ci Bot commented Dec 16, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94b5c85:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo

TkDodo commented Dec 23, 2021

Copy link
Copy Markdown
Collaborator

could you maybe port this to the v4 docs (base on the alpha branch)? I remember updating that section because the querykeys need to be an array in v4.

Comment thread docs/src/pages/guides/caching.md Outdated
Comment thread docs/src/pages/guides/caching.md Outdated
The example contains at least one inacurate statement,

> It will then cache the data using `'todos'` and `fetchTodos` as the unique identifiers for that cache.

and could benefit from more precise language.
@aryzing

aryzing commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

Corrected suggestions and rebased on alpha branch as requested, new PR here: #3221

@aryzing aryzing closed this Jan 21, 2022
@aryzing aryzing deleted the patch-1 branch January 23, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants