Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7802 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 87 87
Lines 17140 17142 +2
=======================================
+ Hits 16944 16946 +2
Misses 196 196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit 3699adc Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
requested changes
Jun 25, 2026
|
|
||
| #7797 long column names go past width | ||
| test(2377.1, print(data.table(abcdefghijklmnopqrstuvwxyz=1)), output="abcdefghijklmn...", options=list(width=20)) | ||
| test(2377.2, print(data.table(abcdefghijklmnopqrstuvwxyz=1)), output="1 variable not shown: \\[abcdefghijklmn... <num>\\]", options=list(width=20, datatable.print.trunc.cols=TRUE, datatable.print.class=TRUE)) |
Member
There was a problem hiding this comment.
please add a test with more than one column.
- 3 cols: two too long, one not
- 4 cols: one too long, next not, next too long, next not
- etc
Contributor
Author
There was a problem hiding this comment.
i added two tests , are they satisfying what you were excpecting.
thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7797
apply width based truncation to long column names when printing
data.tables, ensuring that table headers and hidden-column footers respect the available console width.