Properly detect availability of BinaryFormatter#121
Open
Martin-Molinero wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 0258688)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from upstream
pythonnet/pythonnet: avoids throwing whenBinaryFormatteris unavailable (it's removed/disabled on modern .NET, incl. net10). Adds aDefaultFormatterFactorythat probesBinaryFormatteronce and falls back toNoopFormatter, plus a settableFormatterFactory.-x(original authorship preserved).Conflict note:
RuntimeData.csdiverged in this fork. Resolved by taking the upstream factory and wiring this fork'sCreateFormatter()fallback toFormatterFactory()(it previously didnew BinaryFormatter()directly, which is what would throw on net10). TheFormatterTypeoverride path is preserved. Builds clean.Relevant since this fork targets net10 where
BinaryFormatterserialization is no longer supported.🤖 Generated with Claude Code