Skip to content

added fmod & fmod_ + generic slicing for tensorbase class v1#219

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

added fmod & fmod_ + generic slicing for tensorbase class v1#219
ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 5, 2017

Copy link
Copy Markdown

After doing some research on slice and objects it seems that overload __getitem ([] operator) can be done using a simple hack since we are using numpy as underlying library for .data member we can pass it directly and wrap it around a TensorBase object when returning it .
This needs to be heavily looked at @swaroopch @iamtrask @cereallarceny

@swaroopch

Copy link
Copy Markdown
Contributor

@radicalrafi The __getitem__ change looks good to me 👍

@iamtrask

iamtrask commented Sep 8, 2017

Copy link
Copy Markdown
Member

@radicalrafi looks like some travis CI issues?

@ghost

ghost commented Sep 8, 2017

Copy link
Copy Markdown
Author

Mostly syntax issue going to fix them asap

@PlasmaByte

Copy link
Copy Markdown

Damn, added this myself and just noticed your pull request. Foolish me, still getting the hang of the workflow and git in general.
Did you solve your issues?

@ghost ghost closed this Oct 3, 2017
madhavajay pushed a commit that referenced this pull request Jun 7, 2021
* fixing broken test

* moving socketIO workers to grid project

* fixing tests
madhavajay pushed a commit that referenced this pull request Jun 7, 2021
* fixing broken test

* moving socketIO workers to grid project

* fixing tests
rasswanth-s pushed a commit to rasswanth-s/PySyft that referenced this pull request Jun 15, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants