Skip to content

Use latest Travis-CI image.#109

Merged
lsetiawan merged 1 commit into
ODM2:masterfrom
ocefpaf:travis-ci_image
Oct 3, 2017
Merged

Use latest Travis-CI image.#109
lsetiawan merged 1 commit into
ODM2:masterfrom
ocefpaf:travis-ci_image

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Oct 3, 2017

Copy link
Copy Markdown
Member

Closes #88

@ocefpaf

ocefpaf commented Oct 3, 2017

Copy link
Copy Markdown
Member Author

@lsetiawan can you take a quick look? I removed the Travis-CI image pin b/c that image will be removed soon. I got all the tests to work as expected by removing the unnecessary stuff in the addons and following the same strategy we used in WOFpy.

Comment thread .travis.yml
- postgresql

addons:
postgresql: "9.5"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 😄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume mysql is built in already?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgresql too but somehow it will be 2.3 😕
So I guess we need to specify a newer version.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3 is the postgis version. I think explicit definition is better so that we know exactly what database versions and extension versions we are using. 😃

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how to specify version of mysql though.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few things and they all failed. I don't really like to pin versions unless we don't have a choice. Without pinning we can catch errors early when something is updated.

@lsetiawan lsetiawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Merging now. 😄

@lsetiawan lsetiawan merged commit 7d3027e into ODM2:master Oct 3, 2017
@emiliom

emiliom commented Oct 3, 2017

Copy link
Copy Markdown
Member

I tried a few things and they all failed. I don't really like to pin versions unless we don't have a choice. Without pinning we can catch errors early when something is updated.

I generally agree with this approach regarding software libraries, but in the case of database systems or other such heavy applications (eg, THREDDS), I prefer to pin to specific versions, as @lsetiawan suggested.

@ocefpaf ocefpaf deleted the travis-ci_image branch October 3, 2017 20:09
@ocefpaf

ocefpaf commented Oct 3, 2017

Copy link
Copy Markdown
Member Author

I prefer to pin to specific versions

Travis-CI uses Ubuntu Trusty. @lsetiawan do you use Ubuntu? Can you suggest a package name-version for me to try in the .travis.yml?

@lsetiawan

Copy link
Copy Markdown
Member

@lsetiawan do you use Ubuntu? Can you suggest a package name-version for me to try in the .travis.yml?

I do use ubuntu. What ubuntu version does travis use?

@ocefpaf

ocefpaf commented Oct 3, 2017

Copy link
Copy Markdown
Member Author

They say the latest image is Trusty. See https://docs.travis-ci.com/user/reference/trusty/
Not sure that that means in terms of version 😄

@lsetiawan

Copy link
Copy Markdown
Member

@ocefpaf try mysql-server-5.6

@ocefpaf

ocefpaf commented Oct 3, 2017

Copy link
Copy Markdown
Member Author

Will do in a moment. (Switched to Windows to solved something very quickly.)

@lsetiawan

Copy link
Copy Markdown
Member

No rush 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants