refactor(solana-test-validator-up): adopt @metamask/local-node-utils#9237
Merged
ulissesferreira merged 6 commits intoJun 24, 2026
Merged
Conversation
65ac099 to
97084d1
Compare
ulissesferreira
added a commit
that referenced
this pull request
Jun 23, 2026
5ef66e6 to
11fc9d3
Compare
ulissesferreira
added a commit
that referenced
this pull request
Jun 23, 2026
11fc9d3 to
ca7c7af
Compare
3 tasks
Battambang
previously approved these changes
Jun 23, 2026
@metamask/local-node-utils
5dca017 to
c041943
Compare
The base branch was changed.
e331fc7 to
0e52f88
Compare
Battambang
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/solana-test-validator-upwith shared utilities from@metamask/local-node-utils.yamldependency for a workspace dependency on@metamask/local-node-utils.@metamask/local-node-utilsso builds resolve the dependency correctly.installSolanaRelease,findSolanaBinaries), including relative-path executable wrappers.Test plan
yarn workspace @metamask/local-node-utils run buildyarn workspace @metamask/solana-test-validator-up run buildyarn workspace @metamask/solana-test-validator-up run testyarn workspace @metamask/solana-test-validator-up run changelog:validateNote
Low Risk
Internal refactor of a dev/E2E installer with behavior preserved via explicit relative wrapper paths and existing tests; no auth, production runtime, or user data paths.
Overview
@metamask/solana-test-validator-upnow delegates shared installer plumbing to@metamask/local-node-utilsinstead of inlining it ininstall.ts. Cache resolution,package.jsonconfig reads, downloads, checksum verification, tar extraction, platform keys, cache cleanup, and Node bin wrappers all come from the shared package; Solana-specific flow (installSolanaRelease,findSolanaBinaries, default Agave release pins) stays in this package.The direct
yamldependency is removed in favor of@metamask/local-node-utils, with TypeScript project references and an updated monorepo dependency graph. Public types are aliased to the sharedArtifactConfig/InstallDependenciesshapes, andinstallExecutableWrapperis called withpathResolution: 'relative'so generatedsolana/solana-test-validatorwrappers keep the same relative-path behavior as before.Reviewed by Cursor Bugbot for commit 0e52f88. Bugbot is set up for automated code reviews on this repo. Configure here.