feat(wallet): wire PreferencesController into default initialization#9232
Open
sirtimid wants to merge 4 commits into
Open
feat(wallet): wire PreferencesController into default initialization#9232sirtimid wants to merge 4 commits into
PreferencesController into default initialization#9232sirtimid wants to merge 4 commits into
Conversation
sirtimid
added a commit
that referenced
this pull request
Jun 23, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add `PreferencesController` to the default wallet initialization set. It has no cross-controller messenger dependencies and its only constructor inputs are `messenger` and `state`, so it wires with a plain namespaced child messenger and no `instanceOptions` slot — per-client values are supplied through the existing `state.PreferencesController` initial state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
e951604 to
a8fd340
Compare
FrederikBolding
requested changes
Jun 23, 2026
Member
There was a problem hiding this comment.
Before we can do this, we will need metamask-extension and metamask-mobile to both be using PreferencesController from core.
Today they have diverged unfortunately.
EDIT: In theory, we may be able to wire in PreferencesController to wallet and override the initialization on extension to use the diverging version. But will depend on whether their state overlaps enough.
Member
Author
@FrederikBolding Mobile is already on vanilla core |
Member
Author
|
@metamaskbot publish-previews |
Member
Yeah, I realized that and added my EDIT. Have you verified that the controller state on extension is a superset of the We should de-risk by creating integration PRs regardless! |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Prove a consumer can keep a diverging superset PreferencesController by supplying its own initialization configuration under the same name, which overrides the package default — the adoption path for clients (e.g. the extension) that cannot converge to the package controller's state shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Re-export `InitializationConfiguration`, `InitFunctionArguments`, and `InstanceState` from the package root so consumers can annotate their own initialization configurations that override a default controller (e.g. the extension overriding the default `PreferencesController`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Wires the
@metamask/preferences-controllerpackage into@metamask/wallet's default initialization. The defaultWalletnow constructs aPreferencesControllerand exposes itsPreferencesController:*messenger actions (getState/stateChangeplus the preference setters).References
Client construction sites (live
main):Jira: N/A
Checklist
🤖 Generated with Claude Code
Note
Medium Risk
Breaking messenger registration affects extension/mobile upgrade paths, though override-by-name is supported and behavior is covered by tests.
Overview
The default
Walletnow bootstrapsPreferencesControllerfrom@metamask/preferences-controller, exposingPreferencesController:*messenger actions (state and preference setters) on the wallet messenger andPreferencesControlleron wallet state.This is a breaking change for apps that already register their own
PreferencesControlleron a shared messenger—they must drop duplicate wiring or face action registration collisions. Clients with a superset controller can still replace the default viainitializationConfigurationswith the samename.The package also exports
InitializationConfiguration,InitFunctionArguments, andInstanceStateso consumers can type custom init overrides. Dependency graph, TS project references, CODEOWNERS, and tests cover the new default and override path.Reviewed by Cursor Bugbot for commit 55f1664. Bugbot is set up for automated code reviews on this repo. Configure here.