Skip to content

ZSTAC-85984 Model center business network bindings#4335

Open
ZStack-Robot wants to merge 4 commits into
feature-5.5.28-aiosfrom
sync/ye.zou/feature/model-center-business-network-5.5.28-aios@@2
Open

ZSTAC-85984 Model center business network bindings#4335
ZStack-Robot wants to merge 4 commits into
feature-5.5.28-aiosfrom
sync/ye.zou/feature/model-center-business-network-5.5.28-aios@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

  • Add schema/API/SDK support for model center business network profile and gateway bindings.
  • Persist business network profile, business gateway, developer gateway, and endpoint state on model service instance groups.
  • Support changing an instance group's business network profile with same-zone/same-cluster/same-backend validation.

Verification

  • ./runMavenProfile sdk
  • ./runMavenProfile apihelper
  • ./runMavenProfile globalconfigdocmd
  • ./runMavenProfile docpremium
  • mvn -P premium -DskipTests -Dmaven.test.skip=true install -pl premium/plugin-premium/ai,premium/test-premium -am
  • ./runMavenProfile premium
  • mvn surefire:test -DsurefireArgLine= -Dtest=AITest -DsubCaseCollectionStrategy=Designated -DcaseFilePath=/tmp/model-center-business-network-cases.txt -DskipJacoco=true (ModelCenterBusinessNetworkCase, pass)

Note: generated artifacts were produced locally; PR-docker verification still needs to be run with zstack + premium mounted.

Resolves: ZSTAC-85984

sync from gitlab !10296

Add the 5.5.28 upgrade schema and regenerated SDK/test helper surfaces for model center business network profile and gateway bindings.

Resolves: ZSTAC-85984

Change-Id: Iae58ab21a2d79ab5aba6ec596f805b7497d5580d
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MatheMatrix, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 17 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4cac0557-1cc9-40c5-8091-19ced529f4eb

📥 Commits

Reviewing files that changed from the base of the PR and between ec6ca91 and 702a57b.

📒 Files selected for processing (11)
  • conf/db/upgrade/V5.5.28__schema.sql
  • sdk/src/main/java/org/zstack/sdk/AddModelCenterAction.java
  • sdk/src/main/java/org/zstack/sdk/ChangeModelServiceInstanceGroupBusinessNetworkProfileAction.java
  • sdk/src/main/java/org/zstack/sdk/ChangeModelServiceInstanceGroupBusinessNetworkProfileResult.java
  • sdk/src/main/java/org/zstack/sdk/DeployAppDevelopmentServiceAction.java
  • sdk/src/main/java/org/zstack/sdk/DeployDistributedModelServiceAction.java
  • sdk/src/main/java/org/zstack/sdk/DeployModelEvalServiceAction.java
  • sdk/src/main/java/org/zstack/sdk/DeployModelServiceAction.java
  • sdk/src/main/java/org/zstack/sdk/MatchModelServiceTemplateWithModelAction.java
  • sdk/src/main/java/org/zstack/sdk/ModelServiceInstanceGroupInventory.java
  • testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/ye.zou/feature/model-center-business-network-5.5.28-aios@@2

Comment @coderabbitai help to get the list of available commands.

Regenerate the Groovy test helper after adding ChangeModelServiceInstanceGroupBusinessNetworkProfileAction so premium integration cases can call the API through ApiHelper.

Resolves: ZSTAC-85984

Change-Id: I9a146060c5fbbefcba38e7057b957d114d29d6e1
Shrink the sourceRoot prefix in host cache unique indexes so the 5.5.28 schema can deploy on the MySQL 5.5 utf8 limit used by PR docker tests.

Resolves: ZSTAC-85984

Change-Id: I0e92c8ad315f8e76d6588b16bb6e63a61d441619
@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Comment from ye.zou:

Docker verification update for ZSTAC-85984:

  • Corrected this MR to use the cross-fork source branch ye.zou/zstack:feature/model-center-business-network-5.5.28-aios@@2; the earlier MR 10295 is superseded because it had an empty diff.
  • Ran in PR docker container verify-model-center-business-network-5528 with zstack + premium mounted.
  • Passed: ./runMavenProfile premium (BUILD SUCCESS).
  • Passed: ./runMavenProfile sdk (BUILD SUCCESS).
  • Passed: ./runMavenProfile apihelper (BUILD SUCCESS). This produced the missing ApiHelper.groovy helper and is now committed.
  • Passed: ./runMavenProfile globalconfigdocmd (BUILD SUCCESS). Generated unrelated globalconfig markdown churn was not committed.
  • Passed: ./runMavenProfile docpremium (BUILD SUCCESS).
  • First Docker AITest attempt exposed a real schema issue: V5.5.28__schema.sql used hostUuid + sourceRoot(512), exceeding MySQL 5.5 InnoDB 767-byte key limit. Fixed in commit 8e303715d8 by shrinking both sourceRoot index prefixes to 191.
  • Passed after fix: cd /zstack/premium/test-premium && mvn surefire:test -DsurefireArgLine= -Dtest=AITest -DsubCaseCollectionStrategy=Designated -DcaseFilePath=/tmp/model-center-business-network-cases.txt -DskipJacoco=true.
  • Result: Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.

@MatheMatrix

Copy link
Copy Markdown
Owner

Comment from ye.zou:

Additional verification for ZSTAC-85984:

  • Ran in the same PR docker container: cd /zstack && ./runMavenProfile grayupgrade.
  • Result: TestGenerateGrayUpgradeConfig ran 1 test, failures 0, errors 0, skipped 0; BUILD SUCCESS.
  • Generated only a trailing-newline churn in premium conf/grayUpgrade/grayUpgrade.json; no material gray upgrade config change was needed and no diff was committed.

Merge feature-5.5.28-aios into the ZSTAC-85984 source branch and keep the model center business network upgrade schema plus generated ApiHelper aligned with the target branch.

Resolves: ZSTAC-85984

Change-Id: I3d6a027303795d04240a0224b9771228f74f7d4d
@MatheMatrix MatheMatrix force-pushed the sync/ye.zou/feature/model-center-business-network-5.5.28-aios@@2 branch 4 times, most recently from 3217d83 to 702a57b Compare June 25, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants