<feature>[mgt-ipv6]: support ipv6 management network#4329
Open
ZStack-Robot wants to merge 1 commit into
Open
Conversation
|
Warning Review limit reached
More reviews will be available in 30 minutes and 24 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (121)
Warning
|
MatheMatrix
force-pushed
the
sync/shixin.ruan/shixin-ZSTAC-79206-5.5.28@@4
branch
3 times, most recently
from
ab05bd8 to
89dc0ff
Compare
| "host", msg.getName(), ORG_ZSTACK_COMPUTE_HOST_10130); | ||
| } | ||
|
|
||
| static void validateManagementEndpoint(APIAddHostMsg msg) { |
Collaborator
There was a problem hiding this comment.
Comment from shixin.ruan:
validateManagementEndpoint 简单的套一层，validateManagementEndpoint 完全没必要
MatheMatrix
reviewed
Jun 26, 2026
| return isValidManagementEndpoint(managementIp) ? null : ORG_ZSTACK_COMPUTE_HOST_10128; | ||
| } | ||
|
|
||
| private static boolean isValidManagementEndpoint(String endpoint) { |
Owner
There was a problem hiding this comment.
Comment from shixin.ruan:
这个套娃型的coding也完全没必要
Collaborator
Author
|
Comment on Comment from shixin.ruan: 重新全部errorcode的使用，不能使用旧的errorcde |
MatheMatrix
reviewed
Jun 26, 2026
| "host", msg.getName(), ORG_ZSTACK_COMPUTE_HOST_10130); | ||
| } | ||
|
|
||
| static void validateManagementEndpoint(APIAddHostMsg msg) { |
Owner
There was a problem hiding this comment.
Comment from shixin.ruan:
已处理：删除 validateManagementEndpoint(APIAddHostMsg) 这层简单 wrapper，APIAddHostMsg 直接 setManagementIp(validateManagementEndpoint(String))。验证：mvn -pl compute -DskipTests install PASS。Commit: 999facd
ZStack-Robot
commented
Jun 26, 2026
| String normalizedIpVersion = ManagementNetworkIpVersionUtils.normalizeIpVersion(ipVersion); | ||
| if (normalizedIpVersion == null) { | ||
| throw new ApiMessageInterceptionException(argerr( | ||
| ORG_ZSTACK_COMPUTE_ZONE_10004, |
Collaborator
Author
There was a problem hiding this comment.
Comment from shixin.ruan:
已处理：zone 管理网 IP version 的新增错误分支重新分配为独立 error code：invalid tag=10008，existing host mismatch=10009，duplicate tag=10010，IPv6 link-local=10011；未修改 i18n。验证：mvn -pl utils,compute -DskipTests install PASS。Commit: 999facd
MatheMatrix
force-pushed
the
sync/shixin.ruan/shixin-ZSTAC-79206-5.5.28@@4
branch
from
999facd to
8466141
Compare
Squashed from feature-5.5.28-IPv6-management-network onto 5.5.28. Resolves: ZSTAC-79206 Test: mvn -Dmaven.repo.local=/tmp/zstack-m2 -P premium -pl test -am -DskipTests test-compile Change-Id: I4835efc0a30b1560dbcd1b9fda33c07e45412d8c
MatheMatrix
force-pushed
the
sync/shixin.ruan/shixin-ZSTAC-79206-5.5.28@@4
branch
from
8466141 to
3b6d635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squashed cherry-pick from feature-5.5.28-IPv6-management-network to 5.5.28. Jira: ZSTAC-79206.
sync from gitlab !10289