Skip to content

<fix>[pciDevice]: add share error code#4328

Open
MatheMatrix wants to merge 1 commit into
feature-5.5.28-aiosfrom
sync/xinhao.huang/fix/gpu-share-spec-device-access@@2
Open

<fix>[pciDevice]: add share error code#4328
MatheMatrix wants to merge 1 commit into
feature-5.5.28-aiosfrom
sync/xinhao.huang/fix/gpu-share-spec-device-access@@2

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

Resolves: ZSTAC-85055

Changes:

  • Add ORG_ZSTACK_PCIDEVICE_10078 for PCI device/spec tenant access validation.

Verification:

  • ./runMavenProfile premium
  • mvn test -Dtest=PremiumTestCaseStabilityTest -Dcases=org.zstack.test.integration.premium.pciDevice.TestGpuDeviceShareTypeCase -Dtimes=1 -DmsgTimeoutMins=2 -DThreadFacade.maxThadNum=4 -DskipJacoco=true

sync from gitlab !10288

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MatheMatrix, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 12e72a7c-2683-4394-89c5-abd2453e6997

📥 Commits

Reviewing files that changed from the base of the PR and between ec6ca91 and aa5d84c.

📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/xinhao.huang/fix/gpu-share-spec-device-access@@2

Comment @coderabbitai help to get the list of available commands.

@MatheMatrix MatheMatrix force-pushed the sync/xinhao.huang/fix/gpu-share-spec-device-access@@2 branch from bf95a2d to e452e45 Compare June 24, 2026 08:18
Add a distinct PCI device access error code.

Test: ./runMavenProfile premium

Test: PremiumTestCaseStabilityTest TestGpuDeviceShareTypeCase

Resolves: ZSTAC-85055

Change-Id: I7cc18aaba38631696ff3f928f2d9d1dfc75add3d
@MatheMatrix MatheMatrix force-pushed the sync/xinhao.huang/fix/gpu-share-spec-device-access@@2 branch from e452e45 to aa5d84c Compare June 24, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant