<feature>[zcenter]: add APICreateSessionForZCenterAccountMsg#4190
Closed
ZStack-Robot wants to merge 1 commit into
Closed
<feature>[zcenter]: add APICreateSessionForZCenterAccountMsg#4190ZStack-Robot wants to merge 1 commit into
ZStack-Robot wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (13)
🚧 Files skipped from review as they are similar to previous changes (13)
Walkthrough新增 ZCenter 会话创建 REST API 与消息事件、示例/文档、参数拦截、错误码、云总线服务实现（按 UUID 或 name+source 查找账户并调用 Session.login）以及对应 SDK 与测试 helper。 变更内容ZCenter 账号会话创建
Sequence DiagramsequenceDiagram
participant Client
participant ApiInterceptor
participant ZCenterAccountManager
participant AccountDAO
participant Session
participant EventBus
Client->>ApiInterceptor: APICreateSessionForZCenterAccountMsg
ApiInterceptor->>ZCenterAccountManager: forward APIMessage
ZCenterAccountManager->>AccountDAO: query by accountUuid or (accountName + source)
AccountDAO-->>ZCenterAccountManager: AccountVO or null
alt account exists and enabled
ZCenterAccountManager->>Session: Session.login(account.getUuid())
Session-->>ZCenterAccountManager: SessionInventory
ZCenterAccountManager->>EventBus: publish APICreateSessionForZCenterAccountEvent(inventory)
else not found or disabled
ZCenterAccountManager->>EventBus: publish APICreateSessionForZCenterAccountEvent with error
end
代码审查工作量评估🎯 3 (中等) | ⏱️ ~20 分钟 诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.java (1)
10-15: ⚡ Quick winREST 路径建议使用复数形式以符合编码规范。
根据编码规范第 1 条 API 设计要求："针对资源使用复数形式"。当前路径为
/zcenter/account/session，建议考虑修改为/zcenter/accounts/sessions以符合规范。不过，考虑到这是 ZCenter 的特殊端点，如果团队有意使用单数形式来表示"为（该）账号创建会话"的语义，可以保持现状。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.java` around lines 10 - 15, 当前 RestRequest 注解的 path 值使用了单数形式 "/zcenter/account/session"，请在 APICreateSessionForZCenterAccountMsg 类上将 RestRequest 的 path 修改为复数规范形式 "/zcenter/accounts/sessions"（即资源与子资源均用复数），确保相应的 API 文档和任何硬编码的客户端调用也一并更新；如果团队决定保留单数形式，请在注释中明确说明并记录该例外以便审查。Source: Coding guidelines
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java (1)
14-15: ⚡ Quick win移除未使用的依赖字段。
CloudBus bus字段被@Autowired注入但从未使用，应当移除以减少不必要的依赖和提高代码清晰度。♻️ 建议的清理
-@Autowired -private CloudBus bus; - `@Override`同时移除对应的 import：
-import org.springframework.beans.factory.annotation.Autowired; -import org.zstack.core.cloudbus.CloudBus;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java` around lines 14 - 15, 在类 ZCenterAccountApiInterceptor 中移除未使用的注入字段 CloudBus bus：删除 private CloudBus bus; 以及关联的 `@Autowired` 注解和对应的 import（例如 org.zstack.core.cloudbus.CloudBus 和若因此不再使用则移除 org.springframework.beans.factory.annotation.Autowired 的 import），同时确认没有其他代码引用 CloudBus bus 后保存编译通过即可。agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java (1)
7-7: 确认 ACCOUNT_RELATED_ERROR(2000) 未被使用，建议处理冗余
ACCOUNT_RELATED_ERROR(2000)仅在agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java（第 7 行）定义，仓库内未发现任何引用；当前ZCenterAccountsErrors仅用于ACCOUNT_NOT_FOUND与ACCOUNT_DISABLED。若该错误码无明确规划用途，可移除；否则建议补充注释说明其预留/分类意图。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java` at line 7, ACCOUNT_RELATED_ERROR(2000) in enum ZCenterAccountsErrors is defined but unused; either remove the enum constant or annotate it as reserved with a clear Javadoc explaining its intended future use. Locate the enum ZCenterAccountsErrors and either delete the ACCOUNT_RELATED_ERROR(2000) entry (and run project build/tests) or replace it with a documented placeholder comment/Javadoc (e.g., "Reserved for future account-related errors") so its purpose is explicit; ensure the enum's numeric ordering/uniqueness remains correct after change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java`:
- Around line 36-38: Validate the incoming msg.getSource before using
AccountSource.valueOf to avoid IllegalArgumentException: in
ZCenterAccountApiInterceptor, when msg.getSource() != null, check it against
AccountSource.values() (e.g. Arrays.stream(AccountSource.values()).anyMatch(a ->
a.name().equals(msg.getSource()))), and if it's invalid throw a clear exception
(or convert to a controlled API exception) rather than letting valueOf throw;
add the required import java.util.Arrays and keep the existing fallback that
sets msg.setSource(AccountSource.Local.name()) only when source is null.
In `@header/src/main/java/org/zstack/header/identity/SessionInventory.java`:
- Around line 101-108: The example builder __example__() fails to initialize
deprecated userUuid which causes NPEs in isAccountSession() and isUserSession()
(they call equals on userUuid); modify __example__() to set
session.setUserUuid(...) following the pattern in valueOf() so that for account
sessions userUuid is set to the same value as accountUuid (use
DocUtils.createFixedUuid(AccountVO.class) or reuse session.getAccountUuid())
ensuring userUuid is non-null in the sample instance.
---
Nitpick comments:
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.java`:
- Around line 10-15: 当前 RestRequest 注解的 path 值使用了单数形式
"/zcenter/account/session"，请在 APICreateSessionForZCenterAccountMsg 类上将
RestRequest 的 path 修改为复数规范形式 "/zcenter/accounts/sessions"（即资源与子资源均用复数），确保相应的 API
文档和任何硬编码的客户端调用也一并更新；如果团队决定保留单数形式，请在注释中明确说明并记录该例外以便审查。
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java`:
- Around line 14-15: 在类 ZCenterAccountApiInterceptor 中移除未使用的注入字段 CloudBus bus：删除
private CloudBus bus; 以及关联的 `@Autowired` 注解和对应的 import（例如
org.zstack.core.cloudbus.CloudBus 和若因此不再使用则移除
org.springframework.beans.factory.annotation.Autowired 的 import），同时确认没有其他代码引用
CloudBus bus 后保存编译通过即可。
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java`:
- Line 7: ACCOUNT_RELATED_ERROR(2000) in enum ZCenterAccountsErrors is defined
but unused; either remove the enum constant or annotate it as reserved with a
clear Javadoc explaining its intended future use. Locate the enum
ZCenterAccountsErrors and either delete the ACCOUNT_RELATED_ERROR(2000) entry
(and run project build/tests) or replace it with a documented placeholder
comment/Javadoc (e.g., "Reserved for future account-related errors") so its
purpose is explicit; ensure the enum's numeric ordering/uniqueness remains
correct after change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 30c90993-ba3b-4cec-8ceb-ccc28f1db355
⛔ Files ignored due to path filters (3)
conf/serviceConfig/zcenterAccount.xmlis excluded by!**/*.xmlconf/springConfigXml/agents/ZCenterAccount.xmlis excluded by!**/*.xmlconf/zstack.xmlis excluded by!**/*.xml
📒 Files selected for processing (8)
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountConstant.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountManager.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEvent.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.javaheader/src/main/java/org/zstack/header/identity/SessionInventory.javaheader/src/main/java/org/zstack/header/message/DocUtils.java
Comment on lines
+36
to
+38
| if (msg.getAccountName() != null && msg.getSource() == null) { | ||
| msg.setSource(AccountSource.Local.name()); | ||
| } |
There was a problem hiding this comment.
验证 source 参数的有效性。
当用户提供了 source 参数时，应当验证其是否为有效的 AccountSource 枚举值。否则在 ZCenterAccountManager.findAccount() 方法（第 83 行）调用 AccountSource.valueOf(msg.getSource()) 时会抛出 IllegalArgumentException，导致未预期的运行时异常。
🛡️ 建议的验证逻辑
if (msg.getAccountName() != null && msg.getSource() == null) {
msg.setSource(AccountSource.Local.name());
}
+
+ if (msg.getSource() != null) {
+ try {
+ AccountSource.valueOf(msg.getSource());
+ } catch (IllegalArgumentException e) {
+ throw new ApiMessageInterceptionException(argerr(
+ "invalid source[%s], must be one of %s",
+ msg.getSource(), Arrays.toString(AccountSource.values())));
+ }
+ }
}注：需要在文件顶部添加 import java.util.Arrays;
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java`
around lines 36 - 38, Validate the incoming msg.getSource before using
AccountSource.valueOf to avoid IllegalArgumentException: in
ZCenterAccountApiInterceptor, when msg.getSource() != null, check it against
AccountSource.values() (e.g. Arrays.stream(AccountSource.values()).anyMatch(a ->
a.name().equals(msg.getSource()))), and if it's invalid throw a clear exception
(or convert to a controlled API exception) rather than letting valueOf throw;
add the required import java.util.Arrays and keep the existing fallback that
sets msg.setSource(AccountSource.Local.name()) only when source is null.
Comment on lines
+101
to
+108
| public static SessionInventory __example__() { | ||
| SessionInventory session = new SessionInventory(); | ||
| session.setUuid(DocUtils.createFixedUuid(SessionVO.class)); | ||
| session.setAccountUuid(DocUtils.createFixedUuid(AccountVO.class)); | ||
| session.setCreateDate(DocUtils.timestamp()); | ||
| session.setExpiredDate(DocUtils.timestampAndAddDays(1)); | ||
| return session; | ||
| } |
There was a problem hiding this comment.
需要初始化 userUuid 字段以避免 NPE。
虽然 userUuid 已标记为 @Deprecated，但 isAccountSession() 和 isUserSession() 方法（第 33-39 行）仍在使用该字段进行 equals 比较。如果 userUuid 为 null，这些方法将抛出 NullPointerException。
参考 valueOf() 方法（第 23-31 行）的实现模式，示例对象也应该设置 userUuid。对于账号会话，通常 userUuid 与 accountUuid 相同。
🔧 建议修复方案
public static SessionInventory __example__() {
SessionInventory session = new SessionInventory();
session.setUuid(DocUtils.createFixedUuid(SessionVO.class));
session.setAccountUuid(DocUtils.createFixedUuid(AccountVO.class));
+ session.setUserUuid(DocUtils.createFixedUuid(AccountVO.class));
session.setCreateDate(DocUtils.timestamp());
session.setExpiredDate(DocUtils.timestampAndAddDays(1));
return session;
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@header/src/main/java/org/zstack/header/identity/SessionInventory.java` around
lines 101 - 108, The example builder __example__() fails to initialize
deprecated userUuid which causes NPEs in isAccountSession() and isUserSession()
(they call equals on userUuid); modify __example__() to set
session.setUserUuid(...) following the pattern in valueOf() so that for account
sessions userUuid is set to the same value as accountUuid (use
DocUtils.createFixedUuid(AccountVO.class) or reuse session.getAccountUuid())
ensuring userUuid is non-null in the sample instance.
MatheMatrix
force-pushed
the
sync/wenhao.zhang/zsv-ldap-4
branch
from
55998c6 to
3bab10e
Compare
Owner
|
Comment from wenhao.zhang: @APIParam(required = false, validEnums = AccountSource.class) 相当于已经做了检查，不需要额外在检查一遍 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovy`:
- Around line 24-51: Update the parameter documentation for the
APICreateSessionForZCenterAccountMsgDoc (the column blocks for "accountUuid" and
"accountName") to state the mutual-exclusion and at-least-one constraint:
explicitly note that callers must provide either accountUuid or accountName but
not both; also add to the "accountName" column or the "source" column text that
when accountName is used and source is omitted it defaults to "Local" (and that
providing accountName with a non-Local source is allowed if supported). Ensure
the descriptions for the "accountUuid", "accountName", and "source" column
entries reference this combined constraint so the doc prevents constructing
invalid requests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 75d641c0-3664-4110-bcfd-545c4e8e7d02
⛔ Files ignored due to path filters (6)
build/pom.xmlis excluded by!**/*.xmlconf/serviceConfig/zcenterAccount.xmlis excluded by!**/*.xmlconf/springConfigXml/agents/ZCenterAccount.xmlis excluded by!**/*.xmlconf/zstack.xmlis excluded by!**/*.xmltest/pom.xmlis excluded by!**/*.xmltestlib/pom.xmlis excluded by!**/*.xml
📒 Files selected for processing (13)
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountConstant.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountManager.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEvent.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEventDoc_zh_cn.groovyagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovyagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.javaheader/src/main/java/org/zstack/header/identity/SessionInventory.javaheader/src/main/java/org/zstack/header/message/DocUtils.javasdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountAction.javasdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountResult.javatestlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
✅ Files skipped from review due to trivial changes (3)
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountConstant.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEventDoc_zh_cn.groovy
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java
🚧 Files skipped from review as they are similar to previous changes (6)
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.java
- header/src/main/java/org/zstack/header/identity/SessionInventory.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEvent.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountManager.java
- header/src/main/java/org/zstack/header/message/DocUtils.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.java
Comment on lines
+24
to
+51
| column { | ||
| name "accountUuid" | ||
| enclosedIn "params" | ||
| desc "账户UUID" | ||
| location "body" | ||
| type "String" | ||
| optional true | ||
| since "5.1.0" | ||
| } | ||
| column { | ||
| name "accountName" | ||
| enclosedIn "params" | ||
| desc "账户名称" | ||
| location "body" | ||
| type "String" | ||
| optional true | ||
| since "5.1.0" | ||
| } | ||
| column { | ||
| name "source" | ||
| enclosedIn "params" | ||
| desc "账户来源" | ||
| location "body" | ||
| type "String" | ||
| optional true | ||
| since "5.1.0" | ||
| values ("Local","OpenLdap","WindowsAD","CAS","OAuth2","ZCenter") | ||
| } |
There was a problem hiding this comment.
文档缺少 accountUuid/accountName 的互斥与二选一约束说明。
当前文档把 accountUuid 与 accountName 都标记为可选，但运行时拦截器实际要求“至少提供一个且不能同时提供”。建议在参数描述中明确该组合约束，并补充 accountName 场景下 source 默认 Local 的行为，避免调用方按文档构造出无效请求。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovy`
around lines 24 - 51, Update the parameter documentation for the
APICreateSessionForZCenterAccountMsgDoc (the column blocks for "accountUuid" and
"accountName") to state the mutual-exclusion and at-least-one constraint:
explicitly note that callers must provide either accountUuid or accountName but
not both; also add to the "accountName" column or the "source" column text that
when accountName is used and source is omitted it defaults to "Local" (and that
providing accountName with a non-Local source is allowed if supported). Ensure
the descriptions for the "accountUuid", "accountName", and "source" column
entries reference this combined constraint so the doc prevents constructing
invalid requests.
Collaborator
Author
|
Comment from yaohua.wu: Review: MR !10147 — ZSV-12403Background (preserved across rounds)
整体实现与 Jira 设计稿高度一致（消息分发、 🟡 P1 — Warning
🟢 P2 / P3 — Suggestion
✅ 已核验 / 对既有机器评论的更正
Verdict: APPROVED（无 P0；2 项 P1 为「请确认」性质，非阻塞）实现质量良好、与设计稿一致、授权链路正确。建议合并前就 #1 Session 池副作用 与 #2 🤖 Robot Reviewer |
MatheMatrix
force-pushed
the
sync/wenhao.zhang/zsv-ldap-4
branch
2 times, most recently
from
f3deced to
627f4df
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovy (1)
24-51:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win补充参数组合约束说明（与运行时校验保持一致）
accountUuid与accountName当前都标为可选，但文档未明确“必须二选一且不能同时传”。同时建议在accountName/source描述中补充：当仅传accountName且未传source时，默认Local。否则调用方会按文档构造出会被拦截器拒绝的请求。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovy` around lines 24 - 51, The documentation currently marks accountUuid and accountName as optional but omits their runtime combination constraint; update the APICreateSessionForZCenterAccountMsgDoc to state that accountUuid and accountName are mutually exclusive and exactly one must be provided (must supply one of accountUuid or accountName, not both), and augment the accountName and source field descriptions to note that if only accountName is provided and source is omitted, source defaults to "Local" (aligning docs with the runtime interceptor/validation logic).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In
`@agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovy`:
- Around line 24-51: The documentation currently marks accountUuid and
accountName as optional but omits their runtime combination constraint; update
the APICreateSessionForZCenterAccountMsgDoc to state that accountUuid and
accountName are mutually exclusive and exactly one must be provided (must supply
one of accountUuid or accountName, not both), and augment the accountName and
source field descriptions to note that if only accountName is provided and
source is omitted, source defaults to "Local" (aligning docs with the runtime
interceptor/validation logic).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 11ceaa60-e309-40ce-970c-7236940b977b
⛔ Files ignored due to path filters (6)
build/pom.xmlis excluded by!**/*.xmlconf/serviceConfig/zcenterAccount.xmlis excluded by!**/*.xmlconf/springConfigXml/agents/ZCenterAccount.xmlis excluded by!**/*.xmlconf/zstack.xmlis excluded by!**/*.xmltest/pom.xmlis excluded by!**/*.xmltestlib/pom.xmlis excluded by!**/*.xml
📒 Files selected for processing (13)
agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountConstant.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountManager.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEvent.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEventDoc_zh_cn.groovyagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.javaagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsgDoc_zh_cn.groovyagents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/compute/ZCenterAccountApiInterceptor.javaheader/src/main/java/org/zstack/header/identity/SessionInventory.javaheader/src/main/java/org/zstack/header/message/DocUtils.javasdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountAction.javasdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountResult.javatestlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
🚧 Files skipped from review as they are similar to previous changes (9)
- sdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountResult.java
- header/src/main/java/org/zstack/header/identity/SessionInventory.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountsErrors.java
- header/src/main/java/org/zstack/header/message/DocUtils.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountEvent.java
- testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/ZCenterAccountManager.java
- agents/zcenter-accounts/src/main/java/org/zstack/zcenter/accounts/api/APICreateSessionForZCenterAccountMsg.java
- sdk/src/main/java/org/zstack/sdk/agents/zcenter/accounts/api/CreateSessionForZCenterAccountAction.java
Resolves: ZSV-12403 Related: ZSV-12257 APIImpact Change-Id: I67627861787a617663746f667a6b76726c696a78
MatheMatrix
force-pushed
the
sync/wenhao.zhang/zsv-ldap-4
branch
from
627f4df to
9cb1fde
Compare
Owner
|
Comment from wenhao.zhang: 转 http://dev.zstack.io:9080/zstackio/zstack/-/merge_requests/10149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: ZSV-12403
Related: ZSV-12257
APIImpact
Change-Id: I67627861787a617663746f667a6b76726c696a78
sync from gitlab !10147