IfcOpenShell 0.8.3-post2 3.9 using none supported python language feature.

[xz-autodesk]

Bug Description

1. install python 3.9.16
2. install ifcopenshell pip install ifcopenshell
3. Run the ifcopenshell command below:

python -m ifcopenshell.simple_spf --json "D:\some.ifc"

we will get error:

Traceback (most recent call last):
  File "<somewhere_of_my_root_dir>\Tools\python-win-intel64-3.9.16\lib\runpy.py", line 188, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "<somewhere_of_my_root_dir>\Tools\python-win-intel64-3.9.16\lib\runpy.py", line 147, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "<somewhere_of_my_root_dir>\Tools\python-win-intel64-3.9.16\lib\runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "<somewhere_of_my_root_dir>\Tools\python-win-intel64-3.9.16\lib\site-packages\ifcopenshell\simple_spf\__init__.py", line 14, in <module>
    from .mvd_info import MvdInfo, LARK_AVAILABLE
  File "<somewhere_of_my_root_dir>\Tools\python-win-intel64-3.9.16\lib\site-packages\ifcopenshell\simple_spf\mvd_info.py", line 112, in <module>
    def parse_semicolon_separated_kv(text: str) -> dict[str, str | list[str]] | None:
TypeError: unsupported operand type(s) for |: 'type' and 'types.GenericAlias'

Attachments

No response

Debug and Error Output

[aothms]

Thanks. This appears to have been fixed in ec13294 although the paths have been shuffled a bit.

A new release to pip is overdue @Moult @Andrej730 I don't think there any many open issues that prevent a release

The type annotations is one of the major sources for incompatibility between python version, please also note that from this month onwards python 3.9 is EOL https://devguide.python.org/versions/

[Andrej730]

Ahh, we pushed 0.8.4 release just today, but missed this issue. 0.8.4 suppose to be the last release with 3.9 and then we drop support for it. I guess we wait a bit to see if there's anything else that needs a hot fix and submit 0.8.4.post1 next week.

As a quick fix I've submitted Python 3.9 type of annotations to step-file-parser, so we can fix this just for the release.

It seems mvd_info.py is currently duplicated in ifcopenshell package. Shouldn't it live just inside simple_spf?
Since it's intended to be working without ifcopenshell available and if it's needed inside ifcopenshell, then it can be imported with ifcopenshell.simple_spf.mvd_info.
https://github.com/IfcOpenShell/step-file-parser/blob/master/parser/mvd_info.py
https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.8.0/src/ifcopenshell-python/ifcopenshell/util/mvd_info.py
Also @Ghesselink

[Andrej730]

Fixed in https://pypi.org/project/ifcopenshell/0.8.4.post1