Enables logging on agent indexer#9741
Closed
bric3 wants to merge 1 commit into
Closed
Conversation
bric3
added
tag: do not merge
Contributor
|
🎯 Code Coverage 🔗 Commit SHA: aee3429 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017410
Total [baseline] (10.617 s) : 0, 10617069
Agent [candidate] (1.018 s) : 0, 1017862
Total [candidate] (10.694 s) : 0, 10693726
section appsec
Agent [baseline] (1.209 s) : 0, 1208681
Total [baseline] (11.159 s) : 0, 11158552
Agent [candidate] (1.194 s) : 0, 1193852
Total [candidate] (11.003 s) : 0, 11002991
section iast
Agent [baseline] (1.154 s) : 0, 1153638
Total [baseline] (11.025 s) : 0, 11025157
Agent [candidate] (1.152 s) : 0, 1151716
Total [candidate] (10.991 s) : 0, 10991083
section profiling
Agent [baseline] (1.161 s) : 0, 1160714
Total [baseline] (11.054 s) : 0, 11053506
Agent [candidate] (1.163 s) : 0, 1162551
Total [candidate] (11.04 s) : 0, 11040047
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (692.535 ms) : 0, 692535
BytebuddyAgent [candidate] (693.345 ms) : 0, 693345
GlobalTracer [baseline] (241.748 ms) : 0, 241748
GlobalTracer [candidate] (242.458 ms) : 0, 242458
AppSec [baseline] (32.453 ms) : 0, 32453
AppSec [candidate] (32.438 ms) : 0, 32438
Debugger [baseline] (6.45 ms) : 0, 6450
Debugger [candidate] (6.382 ms) : 0, 6382
Remote Config [baseline] (694.28 µs) : 0, 694
Remote Config [candidate] (704.71 µs) : 0, 705
Telemetry [baseline] (9.347 ms) : 0, 9347
Telemetry [candidate] (9.212 ms) : 0, 9212
Flare Poller [baseline] (11.58 ms) : 0, 11580
Flare Poller [candidate] (10.721 ms) : 0, 10721
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (728.414 ms) : 0, 728414
BytebuddyAgent [candidate] (718.089 ms) : 0, 718089
GlobalTracer [baseline] (237.661 ms) : 0, 237661
GlobalTracer [candidate] (234.438 ms) : 0, 234438
AppSec [baseline] (175.462 ms) : 0, 175462
AppSec [candidate] (174.386 ms) : 0, 174386
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (6.145 ms) : 0, 6145
Remote Config [baseline] (626.926 µs) : 0, 627
Remote Config [candidate] (623.081 µs) : 0, 623
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (9.163 ms) : 0, 9163
Flare Poller [baseline] (3.922 ms) : 0, 3922
Flare Poller [candidate] (3.853 ms) : 0, 3853
IAST [baseline] (25.322 ms) : 0, 25322
IAST [candidate] (24.68 ms) : 0, 24680
section iast
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (817.188 ms) : 0, 817188
BytebuddyAgent [candidate] (815.81 ms) : 0, 815810
GlobalTracer [baseline] (232.162 ms) : 0, 232162
GlobalTracer [candidate] (231.58 ms) : 0, 231580
AppSec [baseline] (34.509 ms) : 0, 34509
AppSec [candidate] (35.141 ms) : 0, 35141
Debugger [baseline] (6.103 ms) : 0, 6103
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (606.588 µs) : 0, 607
Remote Config [candidate] (606.866 µs) : 0, 607
Telemetry [baseline] (8.665 ms) : 0, 8665
Telemetry [candidate] (8.731 ms) : 0, 8731
Flare Poller [baseline] (4.178 ms) : 0, 4178
Flare Poller [candidate] (4.26 ms) : 0, 4260
IAST [baseline] (27.351 ms) : 0, 27351
IAST [candidate] (26.536 ms) : 0, 26536
section profiling
ProfilingAgent [baseline] (108.432 ms) : 0, 108432
ProfilingAgent [candidate] (108.815 ms) : 0, 108815
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (720.407 ms) : 0, 720407
BytebuddyAgent [candidate] (720.741 ms) : 0, 720741
GlobalTracer [baseline] (217.519 ms) : 0, 217519
GlobalTracer [candidate] (218.058 ms) : 0, 218058
AppSec [baseline] (32.478 ms) : 0, 32478
AppSec [candidate] (32.549 ms) : 0, 32549
Debugger [baseline] (8.14 ms) : 0, 8140
Debugger [candidate] (6.535 ms) : 0, 6535
Remote Config [baseline] (1.548 ms) : 0, 1548
Remote Config [candidate] (840.143 µs) : 0, 840
Telemetry [baseline] (13.635 ms) : 0, 13635
Telemetry [candidate] (16.28 ms) : 0, 16280
Flare Poller [baseline] (4.203 ms) : 0, 4203
Flare Poller [candidate] (4.173 ms) : 0, 4173
Profiling [baseline] (109.439 ms) : 0, 109439
Profiling [candidate] (109.952 ms) : 0, 109952
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014301
Total [baseline] (8.689 s) : 0, 8689094
Agent [candidate] (1.035 s) : 0, 1035259
Total [candidate] (8.683 s) : 0, 8683242
section iast
Agent [baseline] (1.152 s) : 0, 1151886
Total [baseline] (9.338 s) : 0, 9337856
Agent [candidate] (1.152 s) : 0, 1152408
Total [candidate] (9.278 s) : 0, 9277781
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (692.001 ms) : 0, 692001
BytebuddyAgent [candidate] (704.86 ms) : 0, 704860
GlobalTracer [baseline] (241.403 ms) : 0, 241403
GlobalTracer [candidate] (246.23 ms) : 0, 246230
AppSec [baseline] (32.516 ms) : 0, 32516
AppSec [candidate] (33.446 ms) : 0, 33446
Debugger [baseline] (6.438 ms) : 0, 6438
Debugger [candidate] (6.637 ms) : 0, 6637
Remote Config [baseline] (698.522 µs) : 0, 699
Remote Config [candidate] (701.796 µs) : 0, 702
Telemetry [baseline] (9.205 ms) : 0, 9205
Telemetry [candidate] (9.521 ms) : 0, 9521
Flare Poller [baseline] (9.529 ms) : 0, 9529
Flare Poller [candidate] (11.01 ms) : 0, 11010
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (815.696 ms) : 0, 815696
BytebuddyAgent [candidate] (816.669 ms) : 0, 816669
GlobalTracer [baseline] (231.556 ms) : 0, 231556
GlobalTracer [candidate] (231.602 ms) : 0, 231602
IAST [baseline] (26.405 ms) : 0, 26405
IAST [candidate] (26.532 ms) : 0, 26532
AppSec [baseline] (35.322 ms) : 0, 35322
AppSec [candidate] (34.925 ms) : 0, 34925
Debugger [baseline] (6.157 ms) : 0, 6157
Debugger [candidate] (6.125 ms) : 0, 6125
Remote Config [baseline] (608.357 µs) : 0, 608
Remote Config [candidate] (605.687 µs) : 0, 606
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.667 ms) : 0, 8667
Flare Poller [baseline] (4.314 ms) : 0, 4314
Flare Poller [candidate] (4.275 ms) : 0, 4275
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section baseline
no_agent (4.375 ms) : 4325, 4424
. : milestone, 4375,
iast (9.273 ms) : 9119, 9428
. : milestone, 9273,
iast_FULL (14.055 ms) : 13779, 14331
. : milestone, 14055,
iast_GLOBAL (11.317 ms) : 11113, 11520
. : milestone, 11317,
profiling (9.652 ms) : 9505, 9799
. : milestone, 9652,
tracing (7.819 ms) : 7707, 7930
. : milestone, 7819,
section candidate
no_agent (4.338 ms) : 4288, 4388
. : milestone, 4338,
iast (9.803 ms) : 9640, 9966
. : milestone, 9803,
iast_FULL (14.25 ms) : 13968, 14532
. : milestone, 14250,
iast_GLOBAL (11.001 ms) : 10805, 11198
. : milestone, 11001,
profiling (8.962 ms) : 8813, 9110
. : milestone, 8962,
tracing (7.73 ms) : 7614, 7846
. : milestone, 7730,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section baseline
no_agent (38.061 ms) : 37760, 38362
. : milestone, 38061,
appsec (48.694 ms) : 48236, 49152
. : milestone, 48694,
code_origins (43.111 ms) : 42745, 43477
. : milestone, 43111,
iast (45.523 ms) : 45124, 45923
. : milestone, 45523,
profiling (50.527 ms) : 50004, 51049
. : milestone, 50527,
tracing (45.467 ms) : 45071, 45862
. : milestone, 45467,
section candidate
no_agent (37.347 ms) : 37045, 37650
. : milestone, 37347,
appsec (49.178 ms) : 48750, 49606
. : milestone, 49178,
code_origins (44.396 ms) : 44012, 44781
. : milestone, 44396,
iast (44.663 ms) : 44275, 45051
. : milestone, 44663,
profiling (49.081 ms) : 48602, 49560
. : milestone, 49081,
tracing (44.521 ms) : 44143, 44900
. : milestone, 44521,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section baseline
no_agent (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
appsec (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
iast (18.487 s) : 18487000, 18487000
. : milestone, 18487000,
iast_GLOBAL (18.241 s) : 18241000, 18241000
. : milestone, 18241000,
profiling (15.322 s) : 15322000, 15322000
. : milestone, 15322000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
section candidate
no_agent (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
appsec (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
iast (18.7 s) : 18700000, 18700000
. : milestone, 18700000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.31 s) : 15310000, 15310000
. : milestone, 15310000,
tracing (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~aee34292c2, baseline=1.55.0-SNAPSHOT~06ae965e51
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.439 ms) : 2389, 2489
. : milestone, 2439,
iast (2.191 ms) : 2127, 2254
. : milestone, 2191,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.058 ms) : 2006, 2111
. : milestone, 2058,
tracing (2.014 ms) : 1964, 2064
. : milestone, 2014,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.697 ms) : 3478, 3915
. : milestone, 3697,
iast (2.199 ms) : 2136, 2262
. : milestone, 2199,
iast_GLOBAL (2.24 ms) : 2176, 2304
. : milestone, 2240,
profiling (2.036 ms) : 1985, 2087
. : milestone, 2036,
tracing (2.018 ms) : 1968, 2067
. : milestone, 2018,
|
Contributor
Author
Output of
|
Contributor
Author
|
Identified, that the guard to the log warning should check From @mcculls suggestion: diff --git a/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/AgentJarIndex.java b/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/AgentJarIndex.java
index 168c916d99..f8b0af89e9 100644
--- a/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/AgentJarIndex.java
+++ b/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/AgentJarIndex.java
@@ -143,7 +143,13 @@ public final class AgentJarIndex {
String entryKey = computeEntryKey(prefixRoot.relativize(file));
if (null != entryKey) {
int existingPrefixId = prefixTrie.apply(entryKey);
- if (-1 != existingPrefixId && prefixId != existingPrefixId) {
+ // warn if two subsections contain content under the same package prefix
+ // because we're then unable to redirect requests to the right submodule
+ // (ignore the two 'datadog.compiler' packages which allow duplication)
+ if (existingPrefixId > 0
+ && prefixId != existingPrefixId
+ && !"datadog.compiler.annotations.*".equals(entryKey)
+ && !"datadog.compiler.utils.*".equals(entryKey)) {
log.warn(
"Detected duplicate content under '{}'. Ensure your content is under a distinct directory.",
entryKey);This'll be fixed in #9725. However we found that annotations should appear only once, and will be filtered out from the included jar in this PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
It simply enables logging on the agent indexer.
Motivation
Need to understand the following warnings when running
./gradlew :dd-java-agent:generateAgentJarIndex, see #9725 (comment)Output of
:dd-java-agent:generateAgentJarIndexonmaster06ae965 on 2025-10-13 13:33Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]