feat: emit inferred aws.alb span for ALB-triggered Lambdas#838
Draft
chemystery09 wants to merge 2 commits into
Draft
feat: emit inferred aws.alb span for ALB-triggered Lambdas#838chemystery09 wants to merge 2 commits into
chemystery09 wants to merge 2 commits into
Conversation
When a Lambda is invoked behind an Application Load Balancer, create an inferred aws.alb span with HTTP request tags and populate ALB HTTP facet tags for http.url, http.route, and http.useragent. FRSLES-851 / APMSVLS-542 Co-authored-by: Cursor <cursoragent@cursor.com>
Cover ALB inferred-span creation, service mapping, inbound trace context, HTTP trigger tags, and full wrapper lifecycle including status code and parent/child linkage. FRSLES-851 / APMSVLS-542 Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_inferred_span_from_alb_eventto emit an inferredaws.albspan (span_type=http,span.kind=server) for single-value ALB Lambda events, with HTTP request tags (http.method,http.url,http.useragent, etc.).create_inferred_spanusingEventSubtypes.ALB.extract_http_tagsfor ALB events (norequestContext.stage) sohttp.url,http.route, andhttp.useragentare populated and copied onto the inferred span by the wrapper post-response.Closes FRSLES-851 / APMSVLS-542.
Test plan
pytest tests/test_trigger.py -k application_load_balancer -vpytest tests/test_tracing.py tests/test_wrapper.py -vMade with Cursor