fail websocket handshake on invalid sec-websocket-accept#2211
Merged
hyperxpro merged 1 commit intoJun 23, 2026
Conversation
hyperxpro
approved these changes
Jun 23, 2026
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSocket upgrade continues after a failed challenge check
When the server's Sec-WebSocket-Accept doesn't match the key (or the header is absent),
upgrade()aborts the future but does not return, so it goes on to swap in the WebSocket pipeline and callonOpenon the listener. RFC 6455 section 4.1 requires the client to fail the connection here, which is what the sibling handshake check right above already does. Added the missing return so a bad or missing accept value ends the connection instead of surfacing an unverified peer as an open WebSocket.Covered by a new test that drives the client against a server returning a 101 with a wrong Sec-WebSocket-Accept and asserts onOpen never fires.