fix: do not wait_idle on endpoint close#1753
Merged
Merged
Conversation
dignifiedquire
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a longer debugging session with @dignifiedquire we found out that
wait_idlewill always wait on a close timer for a few 100 ms before actually completing. If application layer protocols always take care of finishing their work (which we do) this is not needed at all. Also the magicsock will very likely stay around long enough to still send out the close frame.This together with #1752 brings the runtime of the
derp_connect_looptest down from 15s to 4s on my machine! First round is 2-3s (due to bugs in netcheck making it too slow likely) and subsequent round are all >500ms!Notes & open questions
Change checklist