fix(iroh): handle rpc args in any position#1739
Merged
Merged
Conversation
rklaehn
reviewed
Oct 26, 2023
| pub struct StartOptions { | ||
| pub addr: SocketAddr, | ||
| pub rpc_port: RpcPort, | ||
| pub rpc_port: u16, |
Contributor
There was a problem hiding this comment.
So we can't start with rpc port disabled anymore?
Contributor
Author
There was a problem hiding this comment.
For now I have removed the ability, yes. Lets work on getting the portless version for rpc supported soon to improve on this.
dignifiedquire
force-pushed
the
fix-rpc-arg
branch
from
a88cb36 to
7f965ba
Compare
Collaborator
|
Something doesn't sit right, netsim works with this though it doesn't pass in |
Arqu
approved these changes
Oct 30, 2023
Arqu
left a comment
Arqu
left a comment
Collaborator
There was a problem hiding this comment.
Other than it magically working when it maybe shouldn't, LGTM.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
divagant-martian
pushed a commit
to divagant-martian/iroh
that referenced
this pull request
Oct 31, 2023
It is now possible to do any of these ``` > iroh start --rpc-port 1234 > iroh --rpc-port 1234 start > iroh console --rpc-port 1234 > iroh --rpc-port 1234 console ``` Closes n0-computer#1639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now possible to do any of these
Closes #1639