fix(iroh-net): split packets on send#1380
Merged
Merged
Conversation
this seems to be the safest way to fix possible GSO/GRO issues on all platforms (Linux and ???) that support them.
6 tasks
Contributor
Author
|
@Arqu once you have a way to test things, can you check if this solves the issue? |
flub
reviewed
Aug 21, 2023
flub
left a comment
flub
left a comment
Contributor
There was a problem hiding this comment.
I think generally this approach is probably the right call for fixing this. we need to do some GSO-like thing properly on the derper channel anyway later.
that way we don't have to reimplement the chunking logic. The downside is that we have to use slice_ref which is a bit scary since it just panics if the content is not a subset. But in this case it is fine I think.
rklaehn
force-pushed
the
use-segment-size
branch
from
8cb3d23 to
b400ec5
Compare
flub
reviewed
Aug 21, 2023
rklaehn
force-pushed
the
use-segment-size
branch
from
2089b90 to
b400ec5
Compare
Contributor
Author
|
I did the following to validate this:
If things are messed up, you get messages like this: |
flub
approved these changes
Aug 21, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this seems to be the safest way to fix possible GSO/GRO issues on all platforms (Linux and ???) that support them.
Description
This is a fix for the possible issues described in #1357 that does the simplest possible thing - just split up the packets before sending them to the derper.
Note that we still get GRO/GSO when we have a direct connection. And since the stream to the derper is a byte stream, unless we flush after each send this should still be rather efficient. The only downside is that the derper has to deal with more individual packets.
Notes & open questions
Does this fix the issue?
Change checklist