diff --git a/.talismanrc b/.talismanrc index ea50cfd..85b46d2 100644 --- a/.talismanrc +++ b/.talismanrc @@ -9,5 +9,5 @@ fileignoreconfig: - filename: test/unit/commands/rollback.test.ts checksum: d1f931f2d9a397131409399ad6463653e28b5a2224e870b641d9ba57c4418f18 - filename: package-lock.json - checksum: e8262e57f73252240a076fa99be712c4d1403c058378cc2bb23f897bb4e45648 + checksum: ffb77989c6fe554cdd79ebe0cbd07c0ce4329dd65b3e9a9089db4abb7b9be2b3 version: "1.0" \ No newline at end of file diff --git a/eslint.config.mjs b/eslint.config.mjs index 582b276..5b39d5c 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -31,4 +31,15 @@ export default tseslint.config( 'max-len': 'off', }, }, + { + files: ['test/**/*.{js,ts}'], + rules: { + 'max-len': 'off', + // chai assertions (e.g. expect(x).to.be.true) read as unused expressions + '@typescript-eslint/no-unused-expressions': 'off', + // test files use @ts-nocheck and scaffolding vars that aren't all referenced + '@typescript-eslint/ban-ts-comment': 'off', + '@typescript-eslint/no-unused-vars': 'off', + }, + }, ); diff --git a/package-lock.json b/package-lock.json index eff20d5..ad591dd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@contentstack/cli-launch", - "version": "1.11.0", + "version": "1.11.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@contentstack/cli-launch", - "version": "1.11.0", + "version": "1.11.1", "license": "MIT", "dependencies": { "@apollo/client": "^3.14.0", @@ -25,7 +25,7 @@ "cross-fetch": "^4.1.0", "dotenv": "^16.4.7", "express": "^4.22.0", - "form-data": "4.0.4", + "form-data": "4.0.6", "graphql": "^16.9.0", "ini": "^3.0.1", "lodash": "^4.18.1", @@ -9484,16 +9484,16 @@ } }, "node_modules/form-data": { - "version": "4.0.4", - "resolved": "https://registry.npmjs.org/form-data/-/form-data-4.0.4.tgz", - "integrity": "sha512-KrGhL9Q4zjj0kiUt5OO4Mr/A/jlI2jDYs5eHBpYHPcBEVSiipAvn2Ko2HnPe20rmcuuvMHNdZFp+4IlGTMF0Ow==", + "version": "4.0.6", + "resolved": "https://registry.npmjs.org/form-data/-/form-data-4.0.6.tgz", + "integrity": "sha512-vKatAh4SlVfgbv+YtmhiRjhEMJsYpsG1Y2rMQtR+SVSbytsSD1YGzDIcrAJmdFec88u/+VoGmxnl+80gL1tRCQ==", "license": "MIT", "dependencies": { "asynckit": "^0.4.0", "combined-stream": "^1.0.8", "es-set-tostringtag": "^2.1.0", - "hasown": "^2.0.2", - "mime-types": "^2.1.12" + "hasown": "^2.0.4", + "mime-types": "^2.1.35" }, "engines": { "node": ">= 6" diff --git a/package.json b/package.json index 07fb4f3..fc360d6 100755 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@contentstack/cli-launch", - "version": "1.11.0", + "version": "1.11.1", "description": "Launch related operations", "author": "Contentstack CLI", "bin": { @@ -36,7 +36,7 @@ "cross-fetch": "^4.1.0", "dotenv": "^16.4.7", "express": "^4.22.0", - "form-data": "4.0.4", + "form-data": "4.0.6", "graphql": "^16.9.0", "ini": "^3.0.1", "lodash": "^4.18.1", @@ -107,7 +107,7 @@ }, "overrides": { "lodash": "^4.18.1", - "form-data": "4.0.4", + "form-data": "4.0.6", "ajv": "^8.18.0", "eslint": { "ajv": "^6.12.6" diff --git a/test/unit/adapters/github.test.ts b/test/unit/adapters/github.test.ts index fcdfd22..8882fdc 100644 --- a/test/unit/adapters/github.test.ts +++ b/test/unit/adapters/github.test.ts @@ -41,6 +41,7 @@ describe('GitHub', () => { checkUserGitHubAccessStub, prepareForNewProjectCreationStub, createNewProjectStub, + selectOrgStub, prepareLaunchConfigStub, showLogsStub, showDeploymentUrlStub, @@ -65,6 +66,7 @@ describe('GitHub', () => { checkUserGitHubAccessStub = stub(GitHub.prototype, 'checkUserGitHubAccess').resolves(true); prepareForNewProjectCreationStub = stub(GitHub.prototype, 'prepareForNewProjectCreation').resolves(); createNewProjectStub = stub(GitHub.prototype, 'createNewProject').resolves(); + selectOrgStub = stub(BaseClass.prototype, 'selectOrg').resolves(); prepareLaunchConfigStub = stub(BaseClass.prototype, 'prepareLaunchConfig').resolves(); showLogsStub = stub(BaseClass.prototype, 'showLogs').resolves(); showDeploymentUrlStub = stub(BaseClass.prototype, 'showDeploymentUrl').resolves(); @@ -81,6 +83,7 @@ describe('GitHub', () => { checkUserGitHubAccessStub.restore(); prepareForNewProjectCreationStub.restore(); createNewProjectStub.restore(); + selectOrgStub.restore(); prepareLaunchConfigStub.restore(); showLogsStub.restore(); showDeploymentUrlStub.restore(); @@ -108,7 +111,7 @@ describe('GitHub', () => { it('should successfully run github flow for existing project when flag redeploy-latest is passed', async () => { getEnvironmentStub.resolves(defaultEnvironment); - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { isExistingProject: true, 'redeploy-latest': true, @@ -133,7 +136,7 @@ describe('GitHub', () => { it('should successfully run github flow for existing project when flag redeploy-latest and environment is passed ', async () => { getEnvironmentStub.resolves(environmentMatchedByEnvironmentFlagInput); - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { isExistingProject: true, 'redeploy-latest': true, @@ -158,7 +161,7 @@ describe('GitHub', () => { it('should exit with non zero status code if deployment fails', async () => { getEnvironmentStub.resolves(defaultEnvironment); - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { isExistingProject: true, 'redeploy-latest': true, @@ -370,7 +373,7 @@ describe('GitHub', () => { }); describe('Deploy new project', () => { - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { isExistingProject: false, }, @@ -440,7 +443,7 @@ describe('GitHub', () => { }); it('should log "New project created successfully" and update the currentConfig if the mutation succeeds', async () => { - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { branch: 'main', provider: 'GitHub', @@ -497,7 +500,7 @@ describe('GitHub', () => { describe('prepareForNewProjectCreation', () => { let selectOrgStub, selectBranchStub, detectFrameworkStub, handleEnvImportFlowStub; - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { flags: { name: 'Test project', @@ -536,7 +539,7 @@ describe('GitHub', () => { describe('checkGitHubConnected', () => { let sandbox; - let adapterConstructorOptions = { + const adapterConstructorOptions = { config: { provider: 'GitHub', userConnection: null,